HttpClient HTTP request/response API method design that provides non racy methods when called outside event-loop#4705
Draft
HttpClient HTTP request/response API method design that provides non racy methods when called outside event-loop#4705
Conversation
Member
Author
|
asking for @tsegismont @jponge opinion more than a review |
Member
|
IIUC, the proposed API enforces the non racy usage that is required with the current API (by taking the transformation chain as a parameter). LGTM, 👍 |
9bf9444 to
21482ac
Compare
21482ac to
aa6c664
Compare
aa6c664 to
9e1e5fb
Compare
…at provides non racy methods when called outside event-loop.
9e1e5fb to
6f96304
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Racy code called from a non event-loop/worker context thread
Instead one should write
This PR shows a new non racy API design
<T> Future<T> request(..., Function<HttpClientRequest, Future<T>>)which provides interesting usability: