allow the 'host' header to be used on HTTP/2 requests if the ':authority' header if missing#5426
Merged
vietj merged 1 commit intoeclipse-vertx:4.xfrom Jan 10, 2025
Merged
Conversation
vietj
reviewed
Dec 20, 2024
…ity' header if missing see eclipse-vertx#5425 Signed-off-by: Jesse White <1379749+j-white@users.noreply.github.com>
tsegismont
approved these changes
Jan 3, 2025
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
This looks good to me, thank you @j-white
Member
|
@j-white could you please send a PR for the main branch as well? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here's a take at solving the issue
happy to take feedback and adjust the solution as needed
see #5425 for context