Skip to content

Deployment options set via sys props are ignored #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsegismont merged 1 commit into from
May 22, 2025
+11 −3
Merged

Deployment options set via sys props are ignored #5575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/vertx/core/impl/launcher/commands/BareCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ protected EventBusOptions getEventBusOptions(JsonObject jsonObject) {
return eventBusOptions;
}

private static final ThreadLocal<Logger> configureFromSystemProperties = new ThreadLocal<>();
protected static final ThreadLocal<Logger> configureFromSystemProperties = new ThreadLocal<>();

/**
* This is used as workaround to retain the existing behavior of the Vert.x CLI and won't be executed
Expand Down
12 changes: 10 additions & 2 deletions src/main/java/io/vertx/core/impl/launcher/commands/RunCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,16 @@ public void run() {
}

deploymentOptions = new DeploymentOptions();
configureFromSystemProperties(deploymentOptions, DEPLOYMENT_OPTIONS_PROP_PREFIX);
deploymentOptions.setConfig(conf).setWorker(worker).setHa(ha).setInstances(instances);
configureFromSystemProperties.set(log);
try {
configureFromSystemProperties(deploymentOptions, DEPLOYMENT_OPTIONS_PROP_PREFIX);
} finally {
configureFromSystemProperties.set(null);
}
deploymentOptions.setConfig(conf).setHa(ha).setInstances(instances);
if (worker) {
deploymentOptions.setThreadingModel(ThreadingModel.WORKER);
}
beforeDeployingVerticle(deploymentOptions);
deploy();
} else {
Expand Down
Loading