HTTP server started on a duplicated context shares contextual data#5590
Closed
tsegismont wants to merge 1 commit intoeclipse-vertx:masterfrom
Closed
HTTP server started on a duplicated context shares contextual data#5590tsegismont wants to merge 1 commit intoeclipse-vertx:masterfrom
tsegismont wants to merge 1 commit intoeclipse-vertx:masterfrom
Conversation
See eclipse-vertx#5589 If the server is started from a duplicated context, the listen context should be the underlying context (unwrapped). And then we should duplicate the unwrapped context. This is to make sure the creating context and the request context are not sharing local data. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
force-pushed
the
server-started-from-a-duplicated-context
branch
from
0dcff51 to
8545572
Compare
Member
Author
|
Superseded by #5606 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5589
If the server is started from a duplicated context, the listen context should be the underlying context (unwrapped).
And then we should duplicate the unwrapped context.
This is to make sure the creating context and the request context are not sharing local data.