Skip to content

Fix initialization and re-computation of expirationTimestamp in Http2ClientConnectionImpl #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahus1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix initialization and re-computation of expirationTimestamp in Http2ClientConnectionImpl #5866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vertx-core/src/main/java/io/vertx/core/http/impl/http2/codec/Http2ClientConnectionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ public class Http2ClientConnectionImpl extends Http2ConnectionImpl implements Ht
this.authority = authority;
this.lifetimeEvictionTimestamp = maxLifetime > 0 ? System.currentTimeMillis() + maxLifetime : Long.MAX_VALUE;
this.handler = connHandler;
// Ensure that the expirationTimestamp is initialized
recycle();
}

@Override
Expand Down Expand Up @@ -199,8 +201,9 @@ private void recycle() {

@Override
void onStreamClosed(Http2Stream s) {
super.onStreamClosed(s);
// Prepare this connection for returning as onStreamClosed() will return it to the pool.
recycle();
super.onStreamClosed(s);
}

@Override
Expand Down
Loading