Add option for setting max query params

[geoand]

Relates to: quarkusio/quarkus#47431

[vietj]

thanks @geoand I am actually wondering why we have such limit, this is probably due to the decoder we use, but in practice I think this should be unbounded because I don't see this limit preventing any kind o DOS kind of style attack

[geoand]

I am actually wondering why we have such limit,

When develoiping this patch, I was wondering the same :)

[vietj]

I am actually wondering why we have such limit,

When develoiping this patch, I was wondering the same :)

maybe we should simply configure the parser with the highest possible limit and spare us supporting an un-necessary configuration knob ?

[geoand]

If you believe that is safe, I'm fine with that

[vietj]

it is safe because the request URI we use is already limited by the maxInitialLineLength

keep the params(String uri, Charset charset, int maxParams, boolean semicolonIsNormalChar) overload for compatibility and pass it the highest possible value

[geoand]

The Netty code mentions Maximum number of query parameters allowed, to mitigate HashDOS. Are you sure we want to remove it?

[vietj]

@geoand let me have a look

[vietj]

@geoand let be safe and proceed as originally intended by this PR

[geoand]

FWIW, I agree

[geoand]

@vietj is there anything more you want me to do about this?

[vietj]

the Eclipse Contributor Agreement validation seems to fail, do you have a valid eclipse account ?

[geoand]

I thought I did as I have done this in the past...

[vietj]

can you double check that ? or what account you have used ?

[geoand]

Yes, I will check later on today

[vietj]

@geoand thanks for updating this to the latest changes in HTTP configuration layer

[geoand]

🙏

[geoand]

I rebased onto the latest master

[vietj]

@geoand Http3ServerFileUploadTest don't seem to pass with this new feature yet

[geoand]

I see. I'll have a look next week