Skip to content

Output lsof information on suspected leakage#5945

Open
ahus1 wants to merge 1 commit intoeclipse-vertx:masterfrom
ahus1:is-5944-show-lsof-output-on-test-failure
Open

Output lsof information on suspected leakage#5945
ahus1 wants to merge 1 commit intoeclipse-vertx:masterfrom
ahus1:is-5944-show-lsof-output-on-test-failure

Conversation

@ahus1
Copy link
Contributor

@ahus1 ahus1 commented Feb 6, 2026

Closes #5944

Motivation:

Show lsof information when the test fails to allow an analysis of what files changes.

Example output:

lsof before:
COMMAND    PID     USER   FD   TYPE             DEVICE  SIZE/OFF     NODE NAME
java    791300 aschwart  cwd    DIR               0,41        32 21285744 /home/aschwart/redhat/workspace/vert.x/vertx-core
java    791300 aschwart  rtd    DIR               0,37       266      256 /
java    791300 aschwart  txt    REG               0,41     12984 20643956 /home/aschwart/.jdks/corretto-17.0.17/bin/java
...

lsof after:
COMMAND    PID     USER   FD   TYPE             DEVICE  SIZE/OFF     NODE NAME
java    791300 aschwart  cwd    DIR               0,41        32 21285744 /home/aschwart/redhat/workspace/vert.x/vertx-core
java    791300 aschwart  rtd    DIR               0,37       266      256 /
java    791300 aschwart  txt    REG               0,41     12984 20643956 /home/aschwart/.jdks/corretto-17.0.17/bin/java
...

@ahus1 ahus1 marked this pull request as ready for review February 6, 2026 16:06
@vietj
Copy link
Member

vietj commented Feb 9, 2026

how does such failure handling work on windows ?

@ahus1
Copy link
Contributor Author

ahus1 commented Feb 9, 2026

@vietj - the detection logic of a leak is still identical. The only change in this PR is to augment the information on failure.

So the behavior of failing/not failing is as before. But when you run on Linux, it will show you the full lsof output and you might be closer to understand why this failed. On Windows and everywhere such a CLI is not available, the output would just be skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileDescriptorLeakDetector should output lsof for analysis

2 participants