Work around HTTP/2 decompression of padded data#5965
Merged
Conversation
Motivation: It seems that Netty HTTP/2 decompression accounts for padding twice, failing the decompression of a response when padding is not zero. Changes: When processing a compressed entity, set padding to zero and refund the padding to the original flow controller immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a regression in the HTTP/2 decompression that does not account correctly the bytes window refund computation when padding is not zero.
This work around handle padding before decompression, making the pipeline function as if there were no padding.