Conversation
vietj
force-pushed
the
fix-out-of-order-socket-end-message
branch
from
36761b6 to
12f2775
Compare
…e all messages have been dispatched. Motivation: The NetSocket implementation directly write the end sentinel message to the pending message queue, ignoging the potentially buffered messages in the connection. Changes: When we consider the message stream ends, we should instead model the last message as a connection message to ensure no reorder happens.
vietj
force-pushed
the
fix-out-of-order-socket-end-message
branch
from
12f2775 to
67e301e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The NetSocket implementation directly write the end sentinel message to the pending message queue, ignoging the potentially buffered messages in the connection.
Changes:
When we consider the message stream ends, we should instead model the last message as a connection message to ensure no reorder happens.