EPoll: Respect extended TCP Keepalive parameters for clients, not just servers#5970
Open
ivu-mawi wants to merge 1 commit intoeclipse-vertx:4.xfrom
Open
EPoll: Respect extended TCP Keepalive parameters for clients, not just servers#5970ivu-mawi wants to merge 1 commit intoeclipse-vertx:4.xfrom
ivu-mawi wants to merge 1 commit intoeclipse-vertx:4.xfrom
Conversation
…CP_KEEPCNT and TCP_KEEPINTVL for clients, not just servers
ivu-mawi
force-pushed
the
epoll-keepalive-extended-params-for-client
branch
from
a174c41 to
4fc2631
Compare
Author
|
I have now tested this locally and it works as expected. Extended keep-alive parameters on TCP Clients are respected only with these changes. Updated PR description to remove reference to pending local test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to use a lower TCP Keepalive interval as a client. Currently this does not work. It does work for servers using the EPoll transport in Vert.x.
This PR makes it work for clients using EPoll.
I noticed that even the code for servers seems to be absent in master / 5.x, maybe worth a "forward-port"?
I have not yet signed the Eclipse Contributor Agreement. I can do that if necessary for this small change.