Stream write result - #6282
Open
vietj wants to merge 2 commits into
Open
Conversation
vietj
changed the title
vietj
force-pushed
the
message-write
branch
2 times, most recently
from
August 8, 2026 13:50
3bb626e to
b4349d6
Compare
Motivation: An HTTP write operation requires currently a MessageWrite implementation along with a Promise to report the write result. We can consolidate both in a single class to save allocations. Changes: Introduce a WritePromise object that extends PromiseImpl and implements MessageWrite. Upon an HTTP write operation, that is passed to the channel and used as return of the write operation.
Motivation: The stream writability API requires a poll after write (writeQueueFull) which can lead to a data race. A stream write could provide the writability as a result of the write operation, improving the implementation of writability poll. Changes: Introduce an internal WriteResult future, aimed to eventually replace stream writeQueueFull. This API is provided currently by HTTP server writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.