OAuth2: Allow empty JWTOptions.audience#732
Merged
tsegismont merged 1 commit intoeclipse-vertx:masterfrom Sep 26, 2025
Merged
Conversation
tsegismont
reviewed
Sep 10, 2025
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thanks for PR @Traderjoe95
Can you amend the first commit so that we can see it's only a renamed class?
Traderjoe95
force-pushed
the
fix/allow-empty-audience-check
branch
from
0948181 to
b3ee676
Compare
Contributor
Author
|
@tsegismont, I simply changed the name back and squashed the commits, that was the quickest. I couldn't come up with a better idea |
tsegismont
approved these changes
Sep 26, 2025
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @Traderjoe95 , that looks good to me
tsegismont
pushed a commit
to tsegismont/vertx-auth
that referenced
this pull request
Sep 26, 2025
tsegismont
added a commit
that referenced
this pull request
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Vert.x 5.0 breaks the option to put an empty array for
JWTOptions.audiencein order to disable the audience check. This is fixed by adding a condition to the audience check. Regression tests are provided for this case and also multiple other cases that were missing.Fixes #731
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines