Improve grpc framing protocol - #297
Merged
Merged
Conversation
Motivation: gRPC protocol only defines trailers for a response, it does not make really sense to have GrpcWriteStreamBase handle it. Changes: Move trailers handling to GrpcServerResponseImpl.
vietj
force-pushed
the
rework-grpc-frames
branch
2 times, most recently
from
August 15, 2026 14:47
b4817b3 to
bf9dbe9
Compare
vietj
force-pushed
the
rework-grpc-frames
branch
from
August 15, 2026 19:09
bf9dbe9 to
41593cf
Compare
vietj
marked this pull request as ready for review
August 15, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.