Unify event bus unary/streaming cases - #298
Merged
Merged
Conversation
As consequence the stream id is only sent initially by the client.
…ate of the write to the remote peer not the success of the interaction
…hat client unary / server streaming are handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Unary and streaming event bus are handled separately.
In addition, the unary/streaming case could be optimized by having the client directly send the message since it is a unary, providing a smaller latency.
Changes:
The unary behavior is merged within the streaming implementations. The streaming implementation has now separate classes for handling inbound and outbound cases depending on the configuration.