Introduce a client to server half close frame. - #309
Merged
Conversation
vietj
force-pushed
the
protocol-updates
branch
from
August 20, 2026 11:03
4a1b201 to
f9023fe
Compare
Motivation: The internal client to server grpc frame protocol uses on the stream end to signal while the server to client uses a trailer frame. That makes the protocol asymetric and implies to specially handle the stream end instead of relying on the sequence of frames. The grpc protocol binding for HTTP/2 specifies an EOS, that we can reify as an hafl close frame. Changes: Introduce a GrpcHalfCloseFrame that signals the last frame sent by the stream. The GrpcFrameType#TRAILERS is renamed to HALF_CLOSE. The GrpcTrailersFrame extends GrpcHalfCloseFrame and carries the necessary baggage for trailers. GrpcStream implementations have been updated accordingly. GrpcReadStream/GrpcWriteStream have been updated accordingly.
vietj
force-pushed
the
protocol-updates
branch
from
August 20, 2026 11:15
f9023fe to
7bff0e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The internal client to server grpc frame protocol uses on the stream end to signal while the server to client uses a trailer frame.
That makes the protocol asymetric and implies to specially handle the stream end instead of relying on the sequence of frames.
The grpc protocol binding for HTTP/2 specifies an EOS, that we can reify as an hafl close frame.
Changes:
Introduce a
GrpcHalfCloseFramethat signals the last frame sent by the stream.The
GrpcFrameType#TRAILERSis renamed toHALF_CLOSE.The
GrpcTrailersFrameextendsGrpcHalfCloseFrame.GrpcStreamimplementations have been updated accordingly.GrpcReadStream/GrpcWriteStreamhave been updated accordingly.