Improve handling of client reset frames sent by the server. - #311
Merged
Conversation
Motivation: Although the server should cancel using a status frame, it can send reset frames as well under some circumstances. The client should properly handle them. Changes: Change client handling of server cancelation reset frame that was actually trying to reset the stream instead of merely reflecting the state and notifying.
vietj
force-pushed
the
test-server-cancelation-reset
branch
from
August 20, 2026 15:53
bb3e65f to
51740ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Although the server should cancel using a status frame, it can send reset frames as well under some circumstances.
The client should properly handle them.
Changes:
Change client handling of server cancelation reset frame that was actually trying to reset the stream instead of merely reflecting the state and notifying.