Fix incorrect cancellation frame write failure handling. - #315
Merged
Conversation
Motivation: The failure write of a cancellation frame triggers the endpoint to be taken down. The implementation rely the stream remote endpoint field and this can be set to null when the stream is closed, resulting in not disposing the endpoint. Changes: Let the write failure uses the capture endpoint reference to attempt to dispose the endpoint.
vietj
force-pushed
the
fix-cancellation-write-failure-endpoint-handling
branch
from
August 24, 2026 17:03
5a3993d to
f5c3752
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The failure write of a cancellation frame triggers the endpoint to be taken down.
The implementation rely the stream remote endpoint field and this can be set to null when the stream is closed, resulting in not disposing the endpoint.
Changes:
Let the write failure uses the capture endpoint reference to attempt to dispose the endpoint.