-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for PWM on Beaglebone black with a kernel > 3.8.13 #273
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Salah-Eddine Missri <[email protected]>
Thanks for the contribution! Is this a debian thing or global? I've never seen such a thing and edison for example has a 3.10 kernel? I'd like to understand if this is a beaglebone thing or general? Quark also uses a 3.8.x kernel and doesn't have this. |
I have only seen this on the Beaglebone black with Debian and Ubuntu. |
Ok I unfortunately don't have a BBB, @tingleby do you think you could take a look? My only arm platform is an rpi2 and that doesn't have pwm (least not natively) |
@cosscat is this something you could help with if you have a board? |
I don't have BBB either, but I've found this nice description: https://github.com/szmoore/MCTX3420/wiki/Software:-PWM-Control and looks like the standard sysfs location is actually just a secondary mean to use PWMs on BBB and the one that doesn't follow the kernel documentation fully (dropping the pwmchip piece). |
I believe this should rather be reworked using |
@alext-mkrs Sure, I'll do it ASAP. |
Thanks and no rush 😄 I just believe this is a better way to go and looking at the code and @arfoll's comments I think it will increase its chances for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to use _replace API before can be merged
So @SyrianSpock, would you be willing to modify this one as requested? |
Tested on hardware (Beaglebone black Rev B6)