fix(@vue-vuetify): reuse the parent AJV by KiaraGrouwstra · Pull Request #2602 · eclipsesource/jsonforms

KiaraGrouwstra · 2026-07-19T12:31:45Z

Reuse the same AJV instance in @vue-vuetify.
Ensures that user configuration of AJV is retained.

Disclaimer: I used a coding agent in the creation of this patch.

netlify · 2026-07-19T12:31:49Z

✅ Deploy Preview for jsonforms-examples ready!

Name	Link
🔨 Latest commit	`758505d`
🔍 Latest deploy log	https://app.netlify.com/projects/jsonforms-examples/deploys/6a5f85ee8e6e91000843c1e8
😎 Deploy Preview	https://deploy-preview-2602--jsonforms-examples.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CLAassistant · 2026-07-19T12:31:51Z

All committers have signed the CLA.

coveralls · 2026-07-20T07:54:11Z

coverage: 83.776%. remained the same — KiaraGrouwstra:reuse-ajv into eclipsesource:master

lucas-koehler

Hi @KiaraGrouwstra ,
thank you very much for contributing to JSON Forms ❤️
I had a look at the change and I don't think it makes a difference:
useJsonForms() of the vue package already injects the JSON Forms core state. Its ajv property should be the same ajv as injected by useAjv(). See useAjvs code here:

jsonforms/packages/vue/src/jsonFormsCompositions.ts

Lines 608 to 620 in 6db5bc8

    
           export function useAjv(): Ajv; 
        
           export function useAjv(optional: true): Ajv | undefined; 
        
           export function useAjv(optional?: true) { 
        
             const jsonforms = optional === true ? useJsonForms(true) : useJsonForms(); 
        
             if (!optional && (!jsonforms?.core || !jsonforms.core.ajv)) { 
        
               throw new Error( 
        
                 "'jsonforms ajv' couldn't be injected. Are you within JSON Forms?" 
        
               ); 
        
             } 
        
             return jsonforms?.core?.ajv as Ajv; 
        
           }

Am I missing something that makes this change necessary?

KiaraGrouwstra · 2026-07-20T09:42:49Z

Hi @lucas-koehler, thanks for your response!
I added a test demonstrating the underlying issue now.

sdirix · 2026-07-21T11:14:38Z

+import { extendedVuetifyRenderers } from '../../../src';
+
+global.ResizeObserver = require('resize-observer-polyfill');
+


This duplicates the vuetify + ResizeObserver bootstrap from tests/unit/util/util.ts. mountJsonForms doesn't take an ajv yet, so extending it with an optional param would let this test reuse the shared helper instead of re-rolling the setup.

lucas-koehler · 2026-07-21T13:04:56Z

@KiaraGrouwstra Sorry for the confusion, I mislooked what excatly useJsonForms returns vs. how ajv is attempted to be extracted from that. Using useAjv instead of course makes sense 👍

…m's AJV Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Kiara Grouwstra <kiara.grouwstra@gmail.com>

Reuse the same AJV instance throughout JSONForms. Ensures that user configuration of AJV is retained. Signed-off-by: Kiara Grouwstra <kiara.grouwstra@gmail.com>

lucas-koehler

LGTM now! Thanks for the contribution ❤️

KiaraGrouwstra force-pushed the reuse-ajv branch from 1f9b485 to 43acbc3 Compare July 19, 2026 12:32

KiaraGrouwstra marked this pull request as draft July 19, 2026 12:38

KiaraGrouwstra force-pushed the reuse-ajv branch 2 times, most recently from 13b618d to 90a7ff6 Compare July 19, 2026 12:54

KiaraGrouwstra changed the title ~~fix(packages): reuse the parent AJV~~ fix(@vue-vuetify): reuse the parent AJV Jul 19, 2026

KiaraGrouwstra marked this pull request as ready for review July 19, 2026 12:58

lucas-koehler reviewed Jul 20, 2026

View reviewed changes

KiaraGrouwstra force-pushed the reuse-ajv branch 2 times, most recently from 7b6d39b to f734784 Compare July 20, 2026 09:38

sdirix reviewed Jul 21, 2026

View reviewed changes

KiaraGrouwstra force-pushed the reuse-ajv branch from f734784 to 5431587 Compare July 21, 2026 14:44

KiaraGrouwstra and others added 2 commits July 21, 2026 16:44

test(@vue-vuetify): test additionalProperties reuses the parent for…

9b40c3e

…m's AJV Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Kiara Grouwstra <kiara.grouwstra@gmail.com>

fix(@vue-vuetify): reuse the parent AJV

758505d

Reuse the same AJV instance throughout JSONForms. Ensures that user configuration of AJV is retained. Signed-off-by: Kiara Grouwstra <kiara.grouwstra@gmail.com>

KiaraGrouwstra force-pushed the reuse-ajv branch from 5431587 to 758505d Compare July 21, 2026 14:45

lucas-koehler approved these changes Jul 21, 2026

View reviewed changes

lucas-koehler added this to the 3.9 milestone Jul 21, 2026

lucas-koehler added vue vuetify labels Jul 21, 2026

lucas-koehler merged commit 32faf9a into eclipsesource:master Jul 21, 2026
10 of 11 checks passed

KiaraGrouwstra deleted the reuse-ajv branch July 21, 2026 16:44

Navigation Menu

Uh oh!

fix(@vue-vuetify): reuse the parent AJV - #2602

fix(@vue-vuetify): reuse the parent AJV#2602
lucas-koehler merged 2 commits into
eclipsesource:masterfrom
KiaraGrouwstra:reuse-ajv

KiaraGrouwstra commented Jul 19, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Jul 19, 2026 •

edited

Loading

Uh oh!

CLAassistant commented Jul 19, 2026 •

edited

Loading

Uh oh!

coveralls commented Jul 20, 2026 •

edited

Loading

Uh oh!

lucas-koehler left a comment

Uh oh!

KiaraGrouwstra commented Jul 20, 2026

Uh oh!

sdirix Jul 21, 2026

Uh oh!

lucas-koehler commented Jul 21, 2026

Uh oh!

lucas-koehler left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	export function useAjv(): Ajv;
	export function useAjv(optional: true): Ajv \| undefined;
	export function useAjv(optional?: true) {
	const jsonforms = optional === true ? useJsonForms(true) : useJsonForms();

	if (!optional && (!jsonforms?.core \|\| !jsonforms.core.ajv)) {
	throw new Error(
	"'jsonforms ajv' couldn't be injected. Are you within JSON Forms?"
	);
	}

	return jsonforms?.core?.ajv as Ajv;
	}

		import { extendedVuetifyRenderers } from '../../../src';

		global.ResizeObserver = require('resize-observer-polyfill');

Uh oh!

Conversation

KiaraGrouwstra commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for jsonforms-examples ready!

Uh oh!

CLAassistant commented Jul 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucas-koehler left a comment

Choose a reason for hiding this comment

Uh oh!

KiaraGrouwstra commented Jul 20, 2026

Uh oh!

sdirix Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

lucas-koehler commented Jul 21, 2026

Uh oh!

lucas-koehler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KiaraGrouwstra commented Jul 19, 2026 •

edited

Loading

netlify Bot commented Jul 19, 2026 •

edited

Loading

CLAassistant commented Jul 19, 2026 •

edited

Loading

coveralls commented Jul 20, 2026 •

edited

Loading