Expose DetailsPanelOverride Plugin Point#115
Draft
ALevansSamsung wants to merge 1 commit intoreuse_timelinefrom
Draft
Expose DetailsPanelOverride Plugin Point#115ALevansSamsung wants to merge 1 commit intoreuse_timelinefrom
ALevansSamsung wants to merge 1 commit intoreuse_timelinefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives an access point to render the contents of the bottom tabs however you want. You will have the name, key, and Mithril Vnode that was going to be rendered.
If paired with a location to render these contents we could have a Theia Widget visualize Perfetto's current selection.
As this part of the UI hasn't been a part of the designs, I could be wrong, I don't feel prepared to build the UI for this.