Closed
Conversation
Implement a little delete badge icon that shows up when hovering on a note head. Clicking the badge deletes the note. For android-graphics/sokatoa#3875 Signed-off-by: Christian W. Damus <cdamus.ext@eclipsesource.com>
Collaborator
|
You responded to my comment before saying "I'd suggest that it shouldn't have been a feature. It's too easy to delete things this way without undo to recover data. We can raise a follow-up ticket if necessary for something to be implemented in Perfetto." I'd argue that this makes it easier to remove the note on accident. Maybe a confirmation dialog would be good in this case, but I also don't know if we NEED an easier way to remove a note. Users can always use the Current Selection Panel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a little delete badge icon that shows up when hovering on a note head. Clicking the badge deletes the note.
For android-graphics/sokatoa#3875
CleanShot.2025-11-19.at.13.06.12.mp4