Skip to content

Fix issue #121; where #118 broke compilation with ENABLE_MPI=OFF#122

Merged
wdeconinck merged 1 commit into
developfrom
121-enable_mpioff-does-not-work
Apr 29, 2026
Merged

Fix issue #121; where #118 broke compilation with ENABLE_MPI=OFF#122
wdeconinck merged 1 commit into
developfrom
121-enable_mpioff-does-not-work

Conversation

@wdeconinck

Copy link
Copy Markdown
Collaborator

Description

This PR fixes #121 after #118 broke compilation with ENABLE_MPI=OFF
The main issue is a compilation issue with MPI_COMM_NULL, and missing export of MPI_COMM_FREE in the mpi_f08_dummy module.

It appears that MPI_COMM_NULL is not even required.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@wdeconinck wdeconinck linked an issue Apr 29, 2026 that may be closed by this pull request
@wdeconinck wdeconinck merged commit ae7a27e into develop Apr 29, 2026
36 checks passed
@wdeconinck wdeconinck deleted the 121-enable_mpioff-does-not-work branch May 6, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENABLE_MPI=OFF does not work

1 participant