Remove OML_INCR_COUNTER mention of IFS routine#124
Merged
Conversation
a1b062e to
8fa93ee
Compare
marsdeno
approved these changes
Jun 5, 2026
marsdeno
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine, although we are still presupposing names of lock-related variables at call site.
flpvana
approved these changes
Jun 5, 2026
flpvana
left a comment
There was a problem hiding this comment.
The best version so far. I would not mind the two different names of compared variables. Both are correct, the first one for users, the other one for bug hunters finding the error message.
Collaborator
Author
|
The routine has actually nothing to do with OML internally it seems; so in principle this could all be handled at call site directly... Fine with this though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Originally authored by @flpvana]
This pull request improves the
OML_INCR_COUNTERsubroutine in theOML_MODmodule, focusing on better error handling and documentation cleanup. The main change is the addition of an optional error output argument to allow external error handling, which makes the routine safer and more flexible. There are also minor corrections to argument intent and documentation.Error handling improvements:
KERRargument toOML_INCR_COUNTERto allow the caller to handle errors externally, instead of always aborting the program. The subroutine now setsKERRto indicate an error ifKexceedsKMAX, and only aborts ifKERRis not provided.Documentation and intent corrections:
OML_INCR_COUNTERand documented the newKERRargument.INTENTof theMYEVENTargument inOML_WAIT_EVENTfromINOUTtoINfor clarity and correctness.