Skip to content

521: derived-drought-historical-monthly uncertainty q02#564

Open
EnisGerxhalija wants to merge 244 commits into
mainfrom
521_drought_unc02
Open

521: derived-drought-historical-monthly uncertainty q02#564
EnisGerxhalija wants to merge 244 commits into
mainfrom
521_drought_unc02

Conversation

@EnisGerxhalija

@EnisGerxhalija EnisGerxhalija commented Feb 25, 2026

Copy link
Copy Markdown
Collaborator

Adds notebooks for the derived-drought-historical-monthly dataset.

Current status:

  • q02: NPL review.

@github-actions

github-actions Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://ecmwf-projects.github.io/c3s2-eqc-quality-assessment/pr-preview/pr-564/

Built to branch gh-pages at 2026-06-12 18:26 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@burggraaff

Copy link
Copy Markdown
Collaborator

@malmans2 the pre-commit hook is failing on the link to https://doi.org/10.1061/(ASCE)0733-9496(2006)132:3(164) which gets converted into a broken Crossref link https://api.crossref.org/works/10.1061/(ASCE/agency, I assume because there is a bracket in the link itself.

I'm guessing this may have come up before, so I'm wondering if you have a known solution? Or do we need to change how the Crossref links are generated in validate-urls.py?

@malmans2

Copy link
Copy Markdown
Member

We should probably eventually automatise it, but I usually just manually replace ( with %28 and ) with %29.
So you URL becomes: https://doi.org/10.1061/%28ASCE%290733-9496%282006%29132:3%28164%29

@burggraaff

Copy link
Copy Markdown
Collaborator

That works, grazie mille!

@burggraaff

Copy link
Copy Markdown
Collaborator

Apologies for the cancelled runs, I forgot to switch to a new branch for testing revisions

@burggraaff

Copy link
Copy Markdown
Collaborator

This is now ready for ECMWF review.

@burggraaff burggraaff marked this pull request as draft May 29, 2026 13:30
@burggraaff burggraaff marked this pull request as ready for review June 12, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants