fix: Use urllib to make _offline() aware of HTTP(s) proxies. #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
socket
package does not respect the environment variablehttp_proxy
. However most (all) download methods used inutils
consider proxies. Therefore, the_offline
test should work with proxies as well.Type of Change
Issue Number
Enable tests on systems that require HTTP proxies.
Code Compatibility
Code Performance and Testing
Dependencies
Documentation
Additional Notes