fix: fetch auth explicitly before checking usage limits to prevent error - #55
Open
vitorrgg wants to merge 1 commit into
Open
fix: fetch auth explicitly before checking usage limits to prevent error#55vitorrgg wants to merge 1 commit into
vitorrgg wants to merge 1 commit into
Conversation
…1 errors Added authentication to API request for order listing and improved error logging for usage limits.
Member
|
A correção na verdade é voltar a funcionar o auth -> #56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lojas com cupons configurados com usage_limit ou total_usage_limit recebiam o erro CANT_CHECK_USAGE_LIMITS com status 409 ao tentar aplicar o desconto.
A causa: checkUsageLimit chamava appSdk.apiRequest(storeId, url) sem passar o objeto auth, dependendo do auto-fetch interno do SDK. Esse mecanismo passou a falhar com 401 para algumas lojas após a migração do Firebase Functions v4 → v5.
Solução
appSdk.getAuth(storeId) é agora chamado explicitamente antes das requisições à Store API, e o auth resultante é passado diretamente para apiRequest — padrão já utilizado em discount-rules.js e get-app-data.js
Adicionado console.error nos dois catch blocks de CANT_CHECK_USAGE_LIMITS para que ocorrências futuras apareçam nos logs do Firebase com o store_id e o erro completo
Impacto
Lojas sem usage_limit configurado não são afetadas (o checkUsageLimit retorna true imediatamente sem fazer nenhuma chamada à API).