Shift $1 out prior to eval #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shift the first positional parameter out into a variable before running the eval command, so that it is not passed onto sourced scripts.
Owner
|
Sorry about the late response. Could you please add a quick test? Thanks! |
edc
requested changes
Jul 19, 2021
Owner
edc
left a comment
edc
left a comment
There was a problem hiding this comment.
I think it's much clearer if we just update L66 to replace bass with $1. WDYT?
|
Is it possible to merge this any time forthcoming? |
mattbailey
pushed a commit
to mattbailey/bass
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shift the first positional parameter out into a variable before running the eval command, so that it is not passed onto sourced scripts.
Fixes #89