Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/email.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class EmailSender: public Fastcgipp::Request<wchar_t>

inline bool send();

bool response()
virtual bool response()
{
out <<
L"Content-Type: text/html; charset=utf-8\r\n\r\n"
Expand Down
4 changes: 2 additions & 2 deletions include/fastcgi++/chunkstreambuf.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ namespace Fastcgipp
//! Empty/flush the buffer
bool emptyBuffer();

~ChunkStreamBuf()
virtual ~ChunkStreamBuf()
{
emptyBuffer();
}
Expand All @@ -109,7 +109,7 @@ namespace Fastcgipp
//! Empty/flush the buffer
bool emptyBuffer();

~ChunkStreamBuf()
virtual ~ChunkStreamBuf()
{
emptyBuffer();
}
Expand Down
2 changes: 1 addition & 1 deletion include/fastcgi++/curler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ namespace Fastcgipp
//! Queue up an curl
void queue(Curl_base& curl);

~Curler();
virtual ~Curler();

//! Construct a Curler object
/*!
Expand Down
3 changes: 2 additions & 1 deletion include/fastcgi++/email.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ namespace Fastcgipp
close();
return std::move(m_data);
}

virtual ~Email_base() = default;
protected:
//! %Email message data
DataRef m_data;
Expand Down Expand Up @@ -132,6 +132,7 @@ namespace Fastcgipp

public:
Email();
~Email() override = default;

//! Set the to address
void to(const std::basic_string<charT>& address);
Expand Down
2 changes: 1 addition & 1 deletion include/fastcgi++/fcgistreambuf.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ namespace Fastcgipp
this->setp(m_buffer, m_buffer+s_buffSize);
}

~FcgiStreambuf()
virtual ~FcgiStreambuf()
{
emptyBuffer();
}
Expand Down
2 changes: 1 addition & 1 deletion include/fastcgi++/mailer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ namespace Fastcgipp
const unsigned short port=25,
unsigned retryInterval=30);

~Mailer();
virtual ~Mailer();

Mailer():
m_initialized(false),
Expand Down
2 changes: 1 addition & 1 deletion include/fastcgi++/manager.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ namespace Fastcgipp
*/
Manager_base(unsigned threads);

~Manager_base();
virtual ~Manager_base();

//! Call from any thread to terminate the Manager
/*!
Expand Down
2 changes: 1 addition & 1 deletion include/fastcgi++/poll.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ namespace Fastcgipp
Result poll(int timeout);

Poll();
~Poll();
virtual ~Poll();
};
}

Expand Down
2 changes: 1 addition & 1 deletion include/fastcgi++/request.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ namespace Fastcgipp
* @param[in] bytesReceived Amount of bytes received in this FastCGI
* record
*/
virtual void inHandler(int bytesReceived)
virtual void inHandler([[maybe_unused]] int bytesReceived)
{}

//! Process custom POST data
Expand Down
4 changes: 2 additions & 2 deletions include/fastcgi++/sockets.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ namespace Fastcgipp
}

//! Calls close() on the socket if we are destructing the original
~Socket();
virtual ~Socket();

//! Returns true if this socket is still open and capable of read/write.
bool valid() const
Expand Down Expand Up @@ -268,7 +268,7 @@ namespace Fastcgipp
public:
SocketGroup();

~SocketGroup();
virtual ~SocketGroup();

//! Listen to the default Fastcgi socket
/*!
Expand Down
2 changes: 1 addition & 1 deletion include/fastcgi++/sql/connection.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ namespace Fastcgipp
int messageType=5432,
unsigned retryInterval=30);

~Connection();
virtual ~Connection();

Connection():
m_initialized(false)
Expand Down
2 changes: 1 addition & 1 deletion include/fastcgi++/transceiver.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ namespace Fastcgipp
const std::function<void(Protocol::RequestId, Message&&)>
sendMessage);

~Transceiver();
virtual ~Transceiver();

//! Listen to the default Fastcgi socket
/*!
Expand Down