fix: RUST_LOG defaulting to error #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eden Reich <[email protected]>
Signed-off-by: Eden Reich <[email protected]>
edenreich
pushed a commit
that referenced
this pull request
Nov 28, 2024
## [1.13.5](v1.13.4...v1.13.5) (2024-11-28) ### Bug Fixes * RUST_LOG defaulting to error ([#42](#42)) ([dc21f05](dc21f05))
Owner
Author
|
🎉 This PR is included in version 1.13.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a new feature to the CLI application, allowing users to set the log level via a command-line argument or environment variable. The most important changes include adding a new
verbosityargument to theClistruct and updating themainfunction to handle this new argument.Enhancements to CLI logging:
cli/src/cli.rs: Added averbosityargument to theClistruct, allowing users to set the log level for the application using either a command-line argument or theRUST_LOGenvironment variable.cli/src/main.rs: Modified themainfunction to check for theRUST_LOGenvironment variable and set the log level based on the newverbosityargument from the CLI. This ensures that the correct log level is used when the application runs.