-
-
Notifications
You must be signed in to change notification settings - Fork 982
Add WorkOS #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add WorkOS #1081
Conversation
Added a border style to the SVG element.
images/svg/workos.svg
Outdated
| aria-label="WorkOS logo" | ||
| viewBox="0 0 512 512" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| width="1080" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this match our existing style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed I think. Can you take a look?
images/svg/workos.svg
Outdated
| width="1080" | ||
| height="1080" | ||
| role="img" | ||
| > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there these extra line breaks here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the height. Also changed the role place.
images/svg/workos.svg
Outdated
| role="img" | ||
| > | ||
| <g fill="#6363f1"> | ||
| <path d="M61.495 238.136c0 7.81 2.13 14.907 5.681 21.295l68.884 119.255c7.1 12.065 17.753 22.003 31.246 26.264 25.563 8.518 53.259-2.13 66.752-24.845l16.33-29.103-65.33-113.574 69.594-119.964 16.332-28.394q7.456-12.777 19.175-21.295H183.636c-18.46 0-36.216 9.938-45.446 26.264L67.175 216.841c-3.549 6.39-5.68 13.487-5.68 21.295"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this path optimised? Are 3 decimal places necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have experience with optimization. Can you tell me how? Thanks!
images/svg/workos.svg
Outdated
| @@ -0,0 +1,13 @@ | |||
| <svg | |||
| aria-label="WorkOS logo" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match our other icons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed I think. Can you take a look?
|
(Moved my comments here) You might be able to reduce the file size by using a clone of one path and rotating by 180 degrees ( Also the photoshop.svg file should not be in this PR. Please try again! |
Seems to be an accident, though I still don't know why the |
|
@DragonSenseiGuy you need to read https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md#shrinking You ticked the box saying that you had read it. The reason for that is to help you understand what we require for this project. |
Yes I used them to optimize it before, but I did not realize that after changing a few things using an SVG editor It reset them. |
|
I've taken a look and it is not in the correct place as it doesn't fit in the green circle area as per the guideline.svg
Once you have adjusted the first path to be in the right place, then giving it an Also, the layout of the file still doesn't match the guidelines given (it even mentions that in the PR template right at the top here!) |

Thank you for your contribution! Before sending this Pull Request, please confirm the following:
python check.pyand received a ✅If you have done the above, please send the Pull Request.
Please also add the hacktober tag.
Also I would appreciate a fast response as hacktober is ending.
Thanks for understanding!