Skip to content

Conversation

@DragonSenseiGuy
Copy link

@DragonSenseiGuy DragonSenseiGuy commented Oct 30, 2025

Thank you for your contribution! Before sending this Pull Request, please confirm the following:

  • I have read the contributing guidelines
  • I have run python check.py and received a ✅
  • The icon's size is under 1,024 Bytes
  • The layout of the SVG looks like this including newlines
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

If you have done the above, please send the Pull Request.

Please also add the hacktober tag.
Also I would appreciate a fast response as hacktober is ending.
Thanks for understanding!

aria-label="WorkOS logo"
viewBox="0 0 512 512"
xmlns="http://www.w3.org/2000/svg"
width="1080"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this match our existing style?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed I think. Can you take a look?

width="1080"
height="1080"
role="img"
>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there these extra line breaks here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the height. Also changed the role place.

role="img"
>
<g fill="#6363f1">
<path d="M61.495 238.136c0 7.81 2.13 14.907 5.681 21.295l68.884 119.255c7.1 12.065 17.753 22.003 31.246 26.264 25.563 8.518 53.259-2.13 66.752-24.845l16.33-29.103-65.33-113.574 69.594-119.964 16.332-28.394q7.456-12.777 19.175-21.295H183.636c-18.46 0-36.216 9.938-45.446 26.264L67.175 216.841c-3.549 6.39-5.68 13.487-5.68 21.295"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this path optimised? Are 3 decimal places necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have experience with optimization. Can you tell me how? Thanks!

@@ -0,0 +1,13 @@
<svg
aria-label="WorkOS logo"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match our other icons.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed I think. Can you take a look?

@jmb
Copy link
Collaborator

jmb commented Oct 30, 2025

(Moved my comments here)
This is very close but does not match the requested file style and does not fit fully in the guideline green circle. Please double check the guidelines.

You might be able to reduce the file size by using a clone of one path and rotating by 180 degrees (<use href="#a" transform="rotate(180, 256, 256)/>)

Also the photoshop.svg file should not be in this PR. Please try again!

@DragonSenseiGuy
Copy link
Author

DragonSenseiGuy commented Oct 30, 2025

Also the photoshop.svg file should not be in this PR. Please try again!

Seems to be an accident, though I still don't know why the python check.py kept changing the file. I remember it changing the file but, I forgot to not git add it.
Thanks!

@edent
Copy link
Owner

edent commented Oct 30, 2025

@DragonSenseiGuy you need to read https://github.com/edent/SuperTinyIcons/blob/master/CONTRIBUTING.md#shrinking

You ticked the box saying that you had read it.

The reason for that is to help you understand what we require for this project.

@DragonSenseiGuy
Copy link
Author

You ticked the box saying that you had read it.

Yes I used them to optimize it before, but I did not realize that after changing a few things using an SVG editor It reset them.
I will make the changes. Thank you.

@jmb
Copy link
Collaborator

jmb commented Oct 30, 2025

I've taken a look and it is not in the correct place as it doesn't fit in the green circle area as per the guideline.svg

image

Once you have adjusted the first path to be in the right place, then giving it an id="a" and doing the use that I mentioned will help reduce the file size. I recommend using https://yqnn.github.io/svg-path-editor/ to play with the rounding and optimise the path - you only need to paste in the d value from a path element.

Also, the layout of the file still doesn't match the guidelines given (it even mentions that in the PR template right at the top here!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants