feat(fileTransfer): limit the file size to the configured free space#749
Open
joshuachp wants to merge 1 commit intoedgehog-device-manager:mainfrom
Open
feat(fileTransfer): limit the file size to the configured free space#749joshuachp wants to merge 1 commit intoedgehog-device-manager:mainfrom
joshuachp wants to merge 1 commit intoedgehog-device-manager:mainfrom
Conversation
3c29aed to
81db1e3
Compare
lucaato
reviewed
Apr 27, 2026
f06a8b3 to
acb3ef6
Compare
fdc4d5e to
8cfdec3
Compare
harlem88
approved these changes
Apr 28, 2026
8cfdec3 to
bbaebe7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
=====================================
Coverage 81.8% 81.8%
=====================================
Files 141 142 +1
Lines 19641 19665 +24
=====================================
+ Hits 16075 16099 +24
Misses 3566 3566
... and 1 file with indirect coverage changes
|
lucaato
reviewed
Apr 29, 2026
Check that a file would not surpass the configured reserved free space on the device. Signed-off-by: Joshua Chapman <joshua.chapman@secomind.com>
bbaebe7 to
90912c9
Compare
lucaato
reviewed
Apr 30, 2026
| size: i64, | ||
| } | ||
|
|
||
| impl StoredFile<String> { |
Collaborator
There was a problem hiding this comment.
This was useful to avoid extra allocations when notifying created files in the finalize_write. Are you sure this is worth it ? It wasn't complicating the code all that much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that a file would not surpass the configured reserved free space
on the device.