refactor: Move file upload and compression to backend#1383
Merged
edgehog-app[bot] merged 2 commits intoedgehog-device-manager:mainfrom Apr 27, 2026
Merged
Conversation
ArnelaL
force-pushed
the
move-file-upload-to-backend
branch
30 times, most recently
from
98ae65d to
dccc5bd
Compare
ArnelaL
force-pushed
the
move-file-upload-to-backend
branch
8 times, most recently
from
4c2e281 to
7890975
Compare
ArnelaL
changed the title
ArnelaL
force-pushed
the
move-file-upload-to-backend
branch
3 times, most recently
from
5c23ba4 to
4626646
Compare
lusergit
requested changes
Apr 27, 2026
Collaborator
lusergit
left a comment
lusergit
left a comment
There was a problem hiding this comment.
Overall this is great 🦸♀️
I have a couple of nits, but once these are solved this sounds good to me
ArnelaL
force-pushed
the
move-file-upload-to-backend
branch
2 times, most recently
from
1422b80 to
9118037
Compare
After updating ash dependencies, new functionality was added to automatically clean up old snapshots and extensions Used command: ``` mix ash.codegen automated_cleanup ``` Signed-off-by: Omar <omar.brbutovic@secomind.com>
ArnelaL
force-pushed
the
move-file-upload-to-backend
branch
from
9118037 to
8171e55
Compare
Previously the frontend would: - request presigned PUT/GET URLs, - upload directly to storage, - then mark records uploaded Now the backend: - receives an `Upload` (GraphQL `Upload`) and uploads it to bucket storage itself - computes digests on the backend - generates compressed variants (`.gz` and `.lz4`) and stores them too - exposes direct URLs (not presigned) via `baseFile/gzFile/lz4File` in GraphQL Signed-off-by: ArnelaL <arnela.lisic@secomind.com>
ArnelaL
force-pushed
the
move-file-upload-to-backend
branch
from
8171e55 to
1c47da0
Compare
lusergit
approved these changes
Apr 27, 2026
Collaborator
|
/fast-forward |
edgehog-app
Bot
merged commit 1c47da0
into
edgehog-device-manager:main
30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously the frontend would:
Now the backend:
Upload(GraphQLUpload) and uploads it to bucketstorage itself
.gzand.lz4) and stores them toobaseFile/gzFile/lz4Filein GraphQL
based on #1347 #1357 #1398
Additional documentation e.g. usage docs, diagrams, reviewer notes, etc.:
Thanks for sending a pull request! If this is your first time, here are some tips for you:
When fixing existing issues, use github's syntax to link your pull request to it
We also have a syntax to signal dependencies to other open pull requests
In case of stacked PRs, you may add the PR number in the last commit's title instead: