Skip to content

style: reintroduce styler#1390

Closed
lusergit wants to merge 2 commits intoedgehog-device-manager:mainfrom
lusergit:push-mwmwprkqrxzs
Closed

style: reintroduce styler#1390
lusergit wants to merge 2 commits intoedgehog-device-manager:mainfrom
lusergit:push-mwmwprkqrxzs

Conversation

@lusergit
Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Styler 1.11 release in march should no longer break compilation of our code.

Source: https://github.com/adobe/elixir-styler/releases/tag/v1.11.0

Additional documentation e.g. usage docs, diagrams, reviewer notes, etc.:


Thanks for sending a pull request! If this is your first time, here are some tips for you:
  1. You can take a look at our developer guide for an introduction on Edgehog development!
  2. Make sure to read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  3. If the PR is unfinished or you're actively working on it, mark it as draft

When fixing existing issues, use github's syntax to link your pull request to it

fixes #<issue number>

We also have a syntax to signal dependencies to other open pull requests

depends on #<pr number>
depends on https://github.com/...

In case of stacked PRs, you may add the PR number in the last commit's title instead:

gitGraph
    commit id: "Current master"
    branch feat1
    checkout feat1
    commit id: "feat: add something"
    commit id: "feat: add something else (#100)"
    branch feat2
    checkout feat2
    commit id: "refactor: do something"
    commit id: "fix: solve issue"
    commit id: "feat: add a feature (#101)"
    branch feat3
    checkout feat3
    commit id: "feat: feat without pr number"
Loading

Styler 1.11 release in march should no longer break compilation of our code.

Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
format with `mix format`

Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
@lusergit lusergit requested review from ArnelaL and Dam-99 April 22, 2026 08:18
@lusergit lusergit marked this pull request as draft April 22, 2026 08:20
@lusergit
Copy link
Copy Markdown
Collaborator Author

Closing this as the new version of Styler introduces a new subtle error: code gets duplicated at every format 😭 I'll report if I find time

@lusergit lusergit closed this Apr 22, 2026
@lusergit lusergit deleted the push-mwmwprkqrxzs branch April 22, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant