kata/runtime: assign GPU devices to multiple containers #1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasten
reviewed
Nov 5, 2025
Pre-release artifacts on a298ee6The pre-release artifacts for this commit are available at the following link: https://contrast-public.s3.eu-central-1.amazonaws.com/pr-artifacts/1762355874/ Created by @thomasten in pr_release_artifacts workflow. |
katexochen
added
bug fix
thomasten
approved these changes
Nov 5, 2025
Member
thomasten
left a comment
thomasten
left a comment
There was a problem hiding this comment.
LGTM and works with Privatemode :)
katexochen
reviewed
Nov 7, 2025
| WithImage("ghcr.io/edgelesssys/contrast/ubuntu:24.04@sha256:0f9e2b7901aa01cf394f9e1af69387e2fd4ee256fd8a95fb9ce3ae87375a31e6"). | ||
| WithCommand("/bin/sh", "-c", "sleep inf"). | ||
| WithEnv(EnvVar(). | ||
| WithName("NVIDIA_VISIBLE_DEVICES").WithValue("all"), |
Member
There was a problem hiding this comment.
Can we add a third container that has the env not set and check that it has no access to the GPU?
katexochen
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1896 (comment) was surprisingly simple to implement. From my testing, both all pod-known GPU(s) and the corresponding Nvidia libs are handed to any container in the pod with
set.
We could potentially expand on this by parsing the actual value of that envvar and using it to only hand through specific GPUs, but
I am also, unfortunately, pretty sure that this is a "forever-patch" and we will not get this merged into upstream kata.