atls: add timeout for optional endorsement fetching #1904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1261, we tried to make the server side timeouts smaller than the client timeouts for SNP, to get better error reporting and feedback from the server side. We added context handling to the `HTTPSGetter` that is used to fetch the SNP endorsements (VCEK, ASK, ARK and CRL) from the KDS. However, the default timeout to fetch the KDS that we introduced in that PR (2m) was much higher than the `ServerHandshake` timeout (25s). The endorsement fetching on the issuer side it _optional_, as the validator can still try to fetch endorsements on their side, so issues with endorsement fetching shouldn't be lethal on the issuer side. Therefore this change introduce another timeout within the issuer that is smaller than the `ServerHandshake`, enabling the issuer to succeed in within the `ServerHandshake` timeout even if the endorsement can't be fetched. The change further improves the documentation around timeouts and improve naming of some things.
katexochen
force-pushed
the
p/kds-timeout
branch
from
56ce44b to
f2c5023
Compare
thomasten
approved these changes
Nov 6, 2025
charludo
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1261, we tried to make the server side timeouts smaller than the client timeouts for SNP, to get better error reporting and feedback from the server side. We added context handling to the
HTTPSGetterthat is used to fetch the SNP endorsements (VCEK, ASK, ARK and CRL) from the KDS. However, the default timeout to fetch the KDS that we introduced in that PR (2m) was much higher than theServerHandshaketimeout (25s).The endorsement fetching on the issuer side it optional, as the validator can still try to fetch endorsements on their side, so issues with endorsement fetching shouldn't be lethal on the issuer side. Therefore this change introduce another timeout within the issuer that is smaller than the
ServerHandshake, enabling the Issuer to succeed in within theServerHandshaketimeout even if the endorsement can't be fetched.The change further improves the documentation around timeouts and improve naming of some things.