e2e: wait for deletion of pods before waiting for readiness #1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have again had an openssl e2e failure. Last time this happened, additional logging was added. Since those logs seem OK, I have the suspicion that a race condition is occurring where
WaitForDeployment(), and the openssl connection attempt that follow it succeed before k8 actually initiated the termination of the deployment from theRestart()func, effectively leading to the restart getting skipped, and the test failing.This PR adds a loop to the
Restart()func which waits for the pod(s) to actually be deleted (or the context to expire).