feat: Query readings without pagination offset#5057
Merged
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom Jan 17, 2025
Merged
feat: Query readings without pagination offset#5057cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
Conversation
Query readings without pagination offset to prevent large dataset query and count. Signed-off-by: bruce <weichou1229@gmail.com> (cherry picked from commit 1a89671151ac64faeeb06f70b556460da8f76616)
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #5057 +/- ##
==========================================
+ Coverage 28.03% 28.15% +0.11%
==========================================
Files 256 256
Lines 18520 18536 +16
==========================================
+ Hits 5193 5218 +25
+ Misses 12129 12097 -32
- Partials 1198 1221 +23 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Query readings without pagination offset to prevent large dataset query and count.
Signed-off-by: bruce weichou1229@gmail.com
(cherry picked from commit 1a89671151ac64faeeb06f70b556460da8f76616)
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
Run core service and query reading without offset, the core data will not use SQL count and offset to prevent performance issue.
New Dependency Instructions (If applicable)