Skip to content

Comments

fix: Add clients to service config#5062

Merged
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
lindseysimple:issue-5054-2
Jan 20, 2025
Merged

fix: Add clients to service config#5062
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
lindseysimple:issue-5054-2

Conversation

@lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented Jan 20, 2025

Relates to #5054. Add clients field to service config.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Relates to edgexfoundry#5054. Add clients field to service config.

Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
@sonarqubecloud
Copy link

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.05%. Comparing base (74c8cdb) to head (6c90d74).

Files with missing lines Patch % Lines
internal/core/data/config/config.go 0.00% 1 Missing ⚠️
internal/core/metadata/config/config.go 0.00% 1 Missing ⚠️
internal/security/proxyauth/config/config.go 0.00% 1 Missing ⚠️
internal/support/notifications/config/config.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5062      +/-   ##
==========================================
- Coverage   28.06%   28.05%   -0.01%     
==========================================
  Files         257      257              
  Lines       18595    18599       +4     
==========================================
  Hits         5218     5218              
- Misses      12156    12160       +4     
  Partials     1221     1221              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit f9a1cad into edgexfoundry:main Jan 20, 2025
7 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-5054-2 branch January 20, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants