Normalize version header names to lower-case #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP headers names are not case-sensitive, so normalize the keys on `Version.headers` to be lower-case strings to simplify usage. This also drops some long-deprecated import format handling where headers were part of `source_metadata`. Fixes #1194.
Mr0grog
added a commit
to edgi-govdata-archiving/web-monitoring-ops
that referenced
this pull request
Apr 2, 2025
Mr0grog
added a commit
that referenced
this pull request
Apr 4, 2025
Should have done this in #1221!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP headers names are not case-sensitive, so normalize the keys on
Version.headersto be lower-case strings to simplify usage. This also drops some long-deprecated import format handling where headers were part ofsource_metadata.Includes a data migration task to normalize all existing headers in version records. Future updates will automatically be normalized by the new code.
Fixes #1194.