Merged
Conversation
During the upgrade from Rails 8.1.1 to 8.1.2 (#1342), I discovered some mess between Rails 8.1 and Minitest 6 caused the app to stop finding tests, meaning it has silently not been running any tests (all 0 of them are passing) in CI since late December or early January. One of those tests was meant to catch Good Job migrations, and did not, since it didn't run. This puts the missing migrations in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the upgrade from Rails 8.1.1 to 8.1.2 (#1342), I discovered some mess between Rails 8.1 and Minitest 6 caused the app to stop finding tests, meaning it has silently not been running any tests (all 0 of them are passing) in CI since late December or early January. One of those tests was meant to catch Good Job migrations, and did not, since it didn't run.
This puts the missing migrations in place.