Skip to content

Use dotenv#247

Merged
Mr0grog merged 4 commits into
edgi-govdata-archiving:mainfrom
MiTo0o:use-dotenv
Apr 4, 2026
Merged

Use dotenv#247
Mr0grog merged 4 commits into
edgi-govdata-archiving:mainfrom
MiTo0o:use-dotenv

Conversation

@MiTo0o

@MiTo0o MiTo0o commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Adds support for python-dotenv to automatically load environment variables from .env files when starting the server, closes #26. I feel like 99% of the time having a try...except for the import won't matter, but technically it's more of a soft dependency and server.py doesn't "need" python-dotenv to run.

@Mr0grog Mr0grog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Sorry it’s taken me a while to catch up on reviews.

Comment thread pyproject.toml Outdated
Comment thread web_monitoring_diff/server/server.py Outdated
@MiTo0o MiTo0o requested a review from Mr0grog March 31, 2026 17:15
Mr0grog added 2 commits April 3, 2026 19:06
This shouldn't happen for library usage; we don't want to alter a runtime environment owned by someone else.

@Mr0grog Mr0grog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! I made a small change to the timing of when it gets loaded and added some docs.

Thanks again for working on this. 👍

@Mr0grog Mr0grog merged commit 495851f into edgi-govdata-archiving:main Apr 4, 2026
16 checks passed
@MiTo0o MiTo0o deleted the use-dotenv branch April 4, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use dotenv for configuring server

2 participants