Replace hackney's usage of certifi with public_key's os cert fetching#509
Open
michaeljguarino wants to merge 1 commit into
Open
Replace hackney's usage of certifi with public_key's os cert fetching#509michaeljguarino wants to merge 1 commit into
michaeljguarino wants to merge 1 commit into
Conversation
Needed for more robust cert trust workflows
Owner
|
Thanks for the PR! I've just merged a major change on the code sorry but would you mind resolving the conflicts and we can get this in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were hitting some snags in enterprise environments due to this, where the simples way to manage private CA's is via trust-manager rewiring
/etc/ssl/certs. The core problem is httpoison/hackney only loads certifi's cert set, so the os level trust bundle is never respected.My guess is we aren't the only users who could need this, so publishing it upstream as well.