feat: added custom image resolver #253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
reviewed
Jul 4, 2024
slaveeks
changed the title
neSpecc
reviewed
Jul 4, 2024
Co-authored-by: Peter Savchenko <[email protected]>
Co-authored-by: Peter Savchenko <[email protected]>
neSpecc
reviewed
Jul 5, 2024
README.md
Outdated
| | -------------- | --------- | ------------- | ------------| | ||
| | resolveUrlByFileData | `fileData`| `Promise.<string>` | Resolve image url by file data | | ||
|
|
||
| `fileData` - any data, which is needed for resolving url |
Contributor
There was a problem hiding this comment.
is it an any data returned from the server?
Closed
| */ | ||
| validate(savedData) { | ||
| return savedData.file && savedData.file.url; | ||
| return savedData.file; |
There was a problem hiding this comment.
Would it not make sense to have similar logic here like we see in the resolveUrlByFileData function. Ie, check that the data contains an url in case a resolver is not defined. To limit how much slack is put on the data guarantees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageResolvermodule for working with custom downloadingimageResolverfield to config, which storesdownloadmethod for custom downloadinginResolvemethod to use data, which is returned after downloading