Skip to content

Support for disabling features in ImageTool #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
idebenone merged 7 commits into from
Oct 29, 2024
Merged

Support for disabling features in ImageTool #269

idebenone merged 7 commits into from
Oct 29, 2024

Conversation

@idebenone
Copy link
Member

@idebenone idebenone commented Sep 30, 2024 •
edited
Loading

Problem:

Users were unable to configure which image tunes (e.g., caption, border, background) should be available in the ImageTool.

Solution:

Implemented a mechanism that allows users to specify which tunes should be available via configuration. If no specific tunes are provided, all default tunes will be available.

closes #29 , closes #236

@idebenone idebenone requested a review from neSpecc September 30, 2024 18:11
neSpecc
neSpecc requested changes Sep 30, 2024
View reviewed changes
@idebenone idebenone requested a review from neSpecc October 3, 2024 11:58
@idebenone
Copy link
Member Author

idebenone commented Oct 3, 2024 •
edited
Loading

@neSpecc

Summary

  • removed caption from tunes.
  • changed the config.features type from array to an object.
  • renamed CSS classes eliminating prefix with for border and background, which aligns with variable names user defines through config.features .

neSpecc
neSpecc requested changes Oct 3, 2024
View reviewed changes
@idebenone idebenone requested a review from neSpecc October 10, 2024 16:35
neSpecc
neSpecc reviewed Oct 14, 2024
View reviewed changes
neSpecc
neSpecc reviewed Oct 18, 2024
View reviewed changes
neSpecc
neSpecc reviewed Oct 27, 2024
View reviewed changes
@idebenone idebenone merged commit b97f7d1 into master Oct 29, 2024
1 check passed
@idebenone idebenone mentioned this pull request Oct 29, 2024
Closed
@idebenone idebenone changed the title Support for selecting and enabling specific tunes in ImageTool Support for disabling features in ImageTool Oct 29, 2024
@idebenone idebenone mentioned this pull request Oct 29, 2024
Closed
@idebenone idebenone deleted the feature/enable-tune-selection branch November 30, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neSpecc neSpecc neSpecc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option to remove caption and extra features (border, stretch, etc.) Disable Settings (caption, withBorder, withBackground, stretched)

3 participants

@idebenone @neSpecc