Skip to content

fix: caption is not visible when the features.caption is set to true #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
idebenone merged 2 commits into from
Jul 1, 2025
Merged

fix: caption is not visible when the features.caption is set to true #294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb38167
fix: caption is not visible when the features.caption is set to true
idebenone Jun 29, 2025
36e5fce
chore: update versions of actions
idebenone Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@editorjs/image",
"version": "2.10.2",
"version": "2.10.3",
"keywords": [
"codex editor",
"image",
Expand Down
3 changes: 3 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ export default class ImageTool implements BlockTool {
public render(): HTMLDivElement {
if (this.config.features?.caption === true || this.config.features?.caption === undefined || (this.config.features?.caption === 'optional' && this.data.caption)) {
this.isCaptionEnabled = true;
this.ui.applyTune('caption', true);
}

return this.ui.render() as HTMLDivElement;
Expand Down Expand Up @@ -403,6 +404,8 @@ export default class ImageTool implements BlockTool {

if (data.caption) {
this.setTune('caption', true);
} else if (this.config.features?.caption === true) {
this.setTune('caption', true);
}
}

Expand Down
Loading