Resize handle #298
Open
Resize handle #298
+107
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoopyDev
force-pushed
the
master
branch
2 times, most recently
from
bfa46c9 to
539b1c9
Compare
Author
|
@neSpecc I see you're a 'vibecode reviewer'...maybe you can review my vibecode? I even cleaned up the lockfiles for you! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, hello there! I'm on a bit of a sprint to make a nice wiki app, because nobody wants to use mediawiki 😅
Anyways, here's the PR:
Summary
Added draggable resize handle to the Image tool; width is stored in block data and reapplied on load.
Clamped resize to a minimum of 40px and to the parent container width to prevent overflow.
Preserves width in saved image data alongside file URL, caption, and tunes.
Handle shrinks to fit small images.
Details
UI: right-edge handle appears on hover; dragging updates inline width and saved width field.
Data: width?: number added to the image block schema and serialization; existing data remains compatible.
Behaviour: width resets to auto when unset; read-only hides the handle.
Testing
Insert image, upload/paste URL.
Drag handle to resize; save/reload and verify width persists.
Confirm min/max clamp (can’t exceed container), handle shrinks with small images, captions/tunes still work, and read-only has no handle.
Notes
No dependency changes; lockfiles unchanged.