fix: two string copy functions in misc in misc.c

[orbisai0security]

Summary

Fix critical severity security issue in src/lib/misc.c.

Vulnerability

Field	Value
ID	V-001
Severity	CRITICAL
Scanner	multi_agent_ai
Rule	V-001
File	src/lib/misc.c:128
CWE	CWE-190

Description: Two string copy functions in misc.c allocate heap buffers using a caller-supplied length value and immediately copy that many bytes via memcpy without any upper-bound validation. At line 128-130, malloc(len) allocates exactly 'len' bytes and memcpy copies 'len' bytes — if 'len' is derived from attacker-controlled input and exceeds the actual string length, or if an integer overflow caused malloc to allocate fewer bytes than intended, the memcpy writes beyond the heap allocation. At line 186-188, malloc(len+1) is susceptible to integer overflow when len equals SIZE_MAX, producing a zero-byte allocation followed by a full-length memcpy overwrite of the entire heap.

Changes

• src/lib/misc.c

Verification

• Build passes
• Scanner re-scan confirms fix
• LLM code review passed

---

Automated security fix by OrbisAI Security