Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-19 clarified leading slash in the spec #68

Merged
merged 1 commit into from
Mar 19, 2025
Merged

GH-19 clarified leading slash in the spec #68

merged 1 commit into from
Mar 19, 2025

Conversation

mipo256
Copy link
Member

@mipo256 mipo256 commented Jan 14, 2025 •
edited by github-actions bot
Loading

Resolves #19

📚 Documentation preview 📚: https://editorconfig-specification--68.org.readthedocs.build/

@mipo256 mipo256 changed the title GH-19 clarified laeding slash in the spec GH-19 clarified leading slash in the spec Jan 14, 2025
@xuhdev
Copy link
Member

xuhdev commented Jan 15, 2025

I think this is good clarification, but we still need to ensure our tests have covered this case

cxw42
cxw42 requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@cxw42 cxw42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mipo256 thanks for the PR! Have you run modified core tests covering this case, as suggested by @xuhdev ? If you could open a corresponding PR in https://github.com/editorconfig/editorconfig-core-test , that would add confidence in this change.

Other than testing, I have one request for a modification to the text.

@mipo256
Copy link
Member Author

mipo256 commented Feb 23, 2025

Added corresponding test: editorconfig/editorconfig-core-test#59

CC: @xuhdev @cxw42

This was referenced Feb 23, 2025
Merged
Open
@mipo256 mipo256 requested a review from cxw42 February 24, 2025 11:12
@mipo256
Copy link
Member Author

mipo256 commented Feb 25, 2025

Hey @cxw42 @xuhdev !
Anything else is required? Kind reminder on this one

@xuhdev
Copy link
Member

xuhdev commented Feb 25, 2025

Could you rebase? I don't have more comment.

@mipo256 mipo256 closed this Mar 1, 2025
@mipo256 mipo256 reopened this Mar 1, 2025
@mipo256 mipo256 force-pushed the master branch 4 times, most recently from b5f26ce to dd73a0f Compare March 1, 2025 16:51
@mipo256
Copy link
Member Author

mipo256 commented Mar 1, 2025

Hey @xuhdev!
Rebased

@mipo256 mipo256 requested a review from xuhdev March 1, 2025 16:52
xuhdev
xuhdev approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @cxw42 What do you think?

@mipo256
Copy link
Member Author

mipo256 commented Mar 7, 2025

@cxw42 ping here

@cxw42 cxw42 enabled auto-merge (squash) March 19, 2025 00:40
@cxw42 cxw42 disabled auto-merge March 19, 2025 00:43
@cxw42
Copy link
Member

cxw42 commented Mar 19, 2025

@mipo256 for some reason it won't let me merge, and I don't have permissions to force-push your mipo256:master. I'm going to have to ask you to rebase and force-push again. Sorry! Thanks for your patience!

@cxw42 cxw42 enabled auto-merge (squash) March 19, 2025 00:50
@mipo256 mipo256 closed this Mar 19, 2025
auto-merge was automatically disabled March 19, 2025 15:53

Pull request was closed

@mipo256 mipo256 reopened this Mar 19, 2025
@mipo256 mipo256 merged commit 15db321 into editorconfig:master Mar 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuhdev xuhdev xuhdev approved these changes

@cxw42 cxw42 cxw42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify the behavior of leading slash in section title
3 participants
@mipo256 @xuhdev @cxw42