Clarified conflicting rules in multiple sections defined in the same .editorconfig file when matched for single file #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuhdev
reviewed
Mar 1, 2025
|
Hey @xuhdev! can you please re-review? I doubt I've understood you correctly, so please check if everything is alright 😄 |
xuhdev
reviewed
Mar 3, 2025
index.rst
Outdated
Comment on lines
217
to
220
| files take precedence. Thus, in case a given file matches multiple sections | ||
| within a single ``.editorconfig`` file, the pairs defined in the section that | ||
| comes later in the ``.editorconfig`` file take precedence over pairs defined | ||
| in the section that comes earlier in the same ``.editorconfig`` file. |
There was a problem hiding this comment.
Sorry for being unclear. I meant the addition can go after the first period of this paragraph ("...take
precedence."), because this addition talks about multiple sections within a single file, which is exactly elaborates what the first sentence says.
….editorconfig file
|
Hey @xuhdev! I've applied the fix, re-review please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #74
📚 Documentation preview 📚: https://editorconfig-specification--75.org.readthedocs.build/