[CLANGDWARF] fix llvm toolchain build issues - #284
Closed
peppergrayxyz wants to merge 10 commits into
Closed
peppergrayxyz wants to merge 10 commits into
peppergrayxyz wants to merge 10 commits into
Conversation
building using clang fails with error `constant-out-of-range-compare` due to `info->vsel_reg == NA` comparing unsigned with `-1` is always false. set `NA` consisently to 0xff Bug: edk2-porting#238 Signed-off-by: Pepper Gray <hello@peppergray.xyz>
`scmi_vccio_sd_s0` needs 17 chars including `\0`, but `SCMI_VOLTAGE_DOMAIN_NAME_LENGTH_MAX` is 16. changed name to `vccio_sd_s0` to fit into buffer Bug: edk2-porting#283 Signed-off-by: Pepper Gray <hello@peppergray.xyz>
`ret` is uninitialized , when no branch matches return `RETURN_INVALID_PARAMETER` in else branch Bug: edk2-porting#283 Signed-off-by: Pepper Gray <hello@peppergray.xyz>
- widen frequency handling for rates above 4.29GHZ (UINT32_MAX) - update gdc handling to avoid long iterations (UINT64_MAX) Bug: edk2-porting#283 Signed-off-by: Pepper Gray <hello@peppergray.xyz>
always write PLLCON2_K_MASK in line with mainline kernel https://github.com/torvalds/linux/blob/238650ef6c7c7cca08e032527329424c9fbd70e5/drivers/clk/rockchip/clk-pll.c#L975 Bug: edk2-porting#283 Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Bug: edk2-porting#283 Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Bug: edk2-porting#283 Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Bug: edk2-porting#283 Signed-off-by: Pepper Gray <hello@peppergray.xyz>
`Pages` and `Buf` are freed without being initialized. `OhciFreeDev` internally calls `FreePool`. After the fall through, `Ohc` is used and accessed and then freed again. - replace separate cleanup labels with a single error path - track controller open/install/init state - unmap memory before freeing it - set return status for non-efi erros Bug: edk2-porting#283 Signed-off-by: Pepper Gray <hello@peppergray.xyz>
placing a label directly before a declaration is officially supported in C23, but triggers an error on clang when compiling with older C standards Bug: edk2-porting#283 Signed-off-by: Pepper Gray <hello@peppergray.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed typo in branch name, new PR: #289